• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ProjectOpenSea / seadrop / 42323193102
89%
main: 81%

Build:
Build:
LAST BUILD BRANCH: ryan/agent-nft-extension
DEFAULT BRANCH: main
Ran 07 Nov 2026 01:25AM UTC
Jobs 1
Files 24
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

07 Nov 2026 01:16AM UTC coverage: 88.514% (-0.4%) from 88.894%
42323193102

push

github

web-flow
Keep v2 temporary locks liftable, end the conduit preapproval after a permanent lock, and drop the per-mint lock read (#206)

## Motivation

Follow-up to [Add ERC-8451 locks to the SeaDrop v2 token
contracts](https://github.com/ProjectOpenSea/seadrop/pull/187), with
three changes:

- Every `ERC1155SeaDrop` mint paid a cold storage read (about 2,100 gas)
for the flag behind "the lock can only become permanent before the first
mint", on every v2 1155 drop, including ones that never lock.
- ERC-8451's Security Considerations
([ethereum/ERCs#2084](https://github.com/ethereum/ERCs/pull/2084),
commit `fd94d3e8`) now cover a temporary lock that outlives whoever
controls it. Renouncing ownership while tokens are locked leaves a lock
no one can lift, while `permanentlyLocked()` stays `false`.
- The same section covers preapproved operators.
`isApprovedForAll(holder, conduit)` kept returning `true` after
`PermanentlyLocked`, which approval scanners report as a live approval.
This was confirmed on the Base test contracts
`0xa7cA7d0cdCD98AD2c8318c5F8684eAb073be5b01` (ERC-721) and
`0xe7b9894Ca923DC01C8013Dd6f00681bA1fE8c384` (ERC-1155).

## Solution

### The before-first-mint check

`_incrementMintCounts` already loads the token id's `totalMinted` for
the max supply check. It now reads the mint-started flag only when that
total is zero, which happens on the first mint of each token id, and
sets it there. Every later mint of the id skips the read.
`lockPermanently()` still reverts with
`CannotLockPermanentlyAfterMint()` once anything was minted, a
zero-amount mint still doesn't count, and burns don't reopen it.
`setMaxSupply` and `lockPermanently()` cost the same as before. This
applies to `ERC1155SeaDrop` and the clone. In the clone the flag already
shared `_CONFIGURER`'s slot, so the saving there is smaller.

An earlier revision of this PR recorded token ids in `setMaxSupply` and
scanned them in `lockPermanently()`. Copilot pointed out that the scan
grows with ev... (continued)

344 of 384 branches covered (89.58%)

Branch coverage included in aggregate %.

36 of 42 new or added lines in 4 files covered. (85.71%)

4 existing lines in 2 files now uncovered.

1521 of 1723 relevant lines covered (88.28%)

6558.89 hits per line

Uncovered Changes

Lines Coverage ∆ File
2
60.53
1.09% src/clones/ERC1155ContractMetadataCloneable.sol
2
92.72
-0.95% src/lib/ERC1155ContractMetadata.sol
2
88.6
-1.03% src/lib/ERC721ContractMetadata.sol

Coverage Regressions

Lines Coverage ∆ File
3
30.0
-40.0% src/lib/ERC1155ConduitPreapproved.sol
1
66.67
-33.33% src/lib/ERC721AConduitPreapproved.sol
Jobs
ID Job ID Ran Files Coverage
1 foundry - 42323193102.1 07 Nov 2026 01:25AM UTC 24
88.51
GitHub Action Run
Source Files on build 42323193102
  • Tree
  • List 24
  • Changed 6
  • Source Changed 4
  • Coverage Changed 6
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #42323193102
  • e19dd094 on github
  • Prev Build on v2 (#42320626037)
  • Next Build on v2 (#42331492608)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc