• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ProjectOpenSea / seadrop / 42320846365
81%

Build:
DEFAULT BRANCH: main
Ran 07 Nov 2026 12:53AM UTC
Jobs 1
Files 31
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

07 Nov 2026 12:52AM UTC coverage: 79.206% (+0.1%) from 79.103%
42320846365

push

github

web-flow
Keep ERC721SeaDropLockable's temporary locks liftable and end the conduit preapproval after a permanent lock (#205)

## Motivation

Follow-up to [Add ERC721SeaDropLockable for ERC-6982 and ERC-8451
locks](https://github.com/ProjectOpenSea/seadrop/pull/186). ERC-8451's
Security Considerations
([ethereum/ERCs#2084](https://github.com/ethereum/ERCs/pull/2084),
commit `fd94d3e8`) now cover two cases that `ERC721SeaDropLockable`
still allowed:

- A temporary lock can outlive whoever controls it. If the owner
renounces ownership while tokens are locked, the lock can never lift,
yet `permanentlyLocked()` stays `false`, so marketplaces keep waiting
for an unlock that can't happen.
- A preapproved operator can't be revoked. `setApprovalForAll(conduit,
false)` succeeds, but `isApprovedForAll(holder, conduit)` keeps
returning `true` after `PermanentlyLocked`, which approval scanners
report as a live approval.

## Solution

### Renouncing during a temporary lock

`renounceOwnership()` now reverts with
`CannotRenounceOwnershipWhileLocked()` while a temporary lock is in
place, meaning the lock isn't permanent and either tokens are locked by
default or any token has its own lock status set to locked. Only the
owner can change the lock in `ERC721SeaDropLockable`, so after a
renounce no one could lift either kind. The owner can unlock first, or
call `lockPermanently()`, after which renouncing works. The owner check
runs first, so a non-owner still gets `OnlyOwner()`.

To cover per-token locks, `ERC8451Lockable` counts tokens whose own
status is locked in a `uint64` that shares the lock flags' storage slot.
`setTokensLocked` updates it only when a token's status changes and
writes it once per call. A token locked this way and later burned still
counts, so the owner unlocks it before renouncing.

### The conduit after a permanent lock

`isApprovedForAll(account, conduit)` returns `false` once
`permanentlyLocked()` is `true`, and the extra read happens only when
the oper... (continued)

193 of 268 branches covered (72.01%)

Branch coverage included in aggregate %.

20 of 20 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

1163 of 1444 relevant lines covered (80.54%)

2322.23 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
66.67
-33.33% src/lib/ERC721AConduitPreapproved.sol
Jobs
ID Job ID Ran Files Coverage
1 foundry - 42320846365.1 07 Nov 2026 12:53AM UTC 31
79.21
GitHub Action Run
Source Files on build 42320846365
  • Tree
  • List 31
  • Changed 4
  • Source Changed 3
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #42320846365
  • 0d3fbf3a on github
  • Prev Build on main (#42320608931)
  • Next Build on main (#42331488280)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc