clay / claycli / 42317383949

87%

master: 86%

Pull #286

github

🍕 vite: clear the build index before the passes start, so a failed pass cannot leave a trusted one

The index was removed in writeJsResults, after both passes had finished. The two
passes run in parallel, so one can write its output while the other fails; the
build then rejected before reaching the removal and the previous index stayed
on disk. A later --changed run for only the repaired pass skipped the pass that
had written (but never committed to the manifest), silently leaving its source
changes out of the deployed assets.

The index is now removed right before the passes run (after the plan has read
it) and still written last, so one on disk always describes a finished build,
whether the build fails in a pass or stops halfway. A test makes the view pass
throw after the Kiln pass wrote its output and checks that no index is left and
the next build runs both passes; verified with real builds as well.

1149 of 1416 branches covered (81.14%)

Branch coverage included in aggregate %.

164 of 164 new or added lines in 5 files covered. (100.0%)

2155 of 2402 relevant lines covered (89.72%)

36.2 hits per line