• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ProjectOpenSea / seadrop / 42311230294
89%
main: 81%

Build:
Build:
LAST BUILD BRANCH: ryan/agent-nft-extension
DEFAULT BRANCH: main
Ran 06 Nov 2026 11:25PM UTC
Jobs 1
Files 20
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

06 Nov 2026 11:20PM UTC coverage: 86.835% (+3.6%) from 83.243%
42311230294

push

github

web-flow
Fix v2 contract bugs found by the Forge port and restore coverage (#195)

## Motivation

Porting the Hardhat suite to Forge in #192 turned up contract bugs that
the specs had papered over. The specs asserted generic errors, and some
of their comments named the wrong one. This fixes those bugs and a few
more found while fixing them. It also cleans up the test helpers the
port left behind and gets coverage working on `v2` again.

## Solution

### Contract fixes

Each fix has tests that fail on the old code.

**1. `_decodeOrder` error reporting**
(`ERC721SeaDropContractOffererImplementation`,
`ERC1155SeaDropContractOffererImplementation`)
- Each validation sets one bit in an error buffer. But the checks tested
`errorBuffer << 254`, `<< 252` and `<< 253`, which keep several low bits
at once. So `InvalidSubstandard` and
`MustSpecifyERC1155ConsiderationItemForSeaDropMint` could never be
raised, and most bad orders reported `UnsupportedExtraDataVersion(0)` or
`InvalidExtraDataEncoding(0)`.
- Empty or one-byte contexts panicked on an out-of-bounds read. So did a
721 order with an empty `minimumReceived`.
- Each bit is now tested on its own, in the intended order: version,
then encoding, then substandard, then `minimumReceived`.
- Allow-list and signed contexts too short to decode now revert
`InvalidExtraDataEncoding` instead of reverting with no data. The
minimum lengths are per substandard.
- I kept the `MustSpecifyERC1155ConsiderationItemForSeaDropMint` name,
since the 721 mint item is also an ERC-1155 item and renaming would
change the ABI.

**2. 1155 wallet-limit errors report what was checked**
- `MintQuantityExceedsMaxMintedPerWalletForTokenId` reported the
wallet's total across every token id, but the check uses the per-token
count. It now reports the per-token count.
- `MintQuantityExceedsMaxMintedPerWallet` reported a single offer item's
quantity instead of the order's running total. Every item is now checked
against the running total, and that total... (continued)

293 of 331 branches covered (88.52%)

Branch coverage included in aggregate %.

52 of 53 new or added lines in 9 files covered. (98.11%)

186 existing lines in 14 files now uncovered.

1290 of 1492 relevant lines covered (86.46%)

7396.64 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
44.44
44.44% src/clones/ERC1155SeaDropCloneable.sol

Coverage Regressions

Lines Coverage ∆ File
52
38.26
38.26% src/clones/ERC1155ContractMetadataCloneable.sol
38
90.21
-5.75% src/lib/ERC1155SeaDropContractOffererImplementation.sol
35
89.53
-7.18% src/lib/ERC721SeaDropContractOffererImplementation.sol
23
72.87
72.87% src/clones/ERC1155SeaDropContractOffererCloneable.sol
7
92.97
-7.03% src/lib/ERC1155SeaDropContractOfferer.sol
7
92.74
-7.26% src/lib/ERC721SeaDropContractOfferer.sol
6
94.83
4.26% src/lib/ERC1155ContractMetadata.sol
6
92.86
1.39% src/lib/ERC721ContractMetadata.sol
4
44.44
44.44% src/clones/ERC1155SeaDropCloneable.sol
3
60.0
2.86% src/lib/ERC1155ConduitPreapproved.sol
2
85.71
-14.29% src/ERC721SeaDrop.sol
1
97.14
-2.86% src/extensions/ERC721SeaDropRandomOffset.sol
1
66.67
-33.33% src/lib/ERC1155SeaDropContractOffererStorage.sol
1
66.67
-33.33% src/lib/ERC721SeaDropContractOffererStorage.sol
Jobs
ID Job ID Ran Files Coverage
1 foundry - 42311230294.1 06 Nov 2026 11:25PM UTC 20
86.83
GitHub Action Run
Source Files on build 42311230294
  • Tree
  • List 20
  • Changed 20
  • Source Changed 0
  • Coverage Changed 20
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #42311230294
  • fcaaa781 on github
  • Prev Build on v2 (#42290081571)
  • Next Build on v2 (#42313060198)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc