• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ProjectOpenSea / seadrop / 42311051763
81%

Build:
DEFAULT BRANCH: main
Ran 06 Nov 2026 11:19PM UTC
Jobs 1
Files 32
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

06 Nov 2026 11:18PM UTC coverage: 75.495% (+1.1%) from 74.375%
42311051763

push

github

web-flow
Fix v1 random offset, multiConfigure and transfer validation bugs (#196)

## Motivation

Porting the v1 Hardhat suite to Forge in #193 turned up contract bugs,
and #194 exposed one more in the upgradeable random offset. This fixes
them in the regular, clone and upgradeable variants. #194 has merged,
and this is rebased onto `main`.

## Solution

Each fix has tests that fail on the old code, run against both the
regular and upgradeable variants.

**1. Random offset range** (`ERC721SeaDropRandomOffset` and the
upgradeable variant)
- `tokenURI` shifts each token's metadata by `randomOffset + 1`, modulo
the max supply. The old code drew `randomOffset` from 1 to N−1. That
made N−1 the identity shift, leaving every token on its own metadata,
and N=2 always landed there. It now draws from 0 to N−2, so the shift is
uniform over the N−1 shifts that move every token.
- `tokenURI` is unchanged, so already-revealed collections keep their
mapping.
- A max supply of 1 divided by zero. It now reveals with offset 0. A max
supply of 0 underflowed; it now reverts `NotFullyMinted`.
- The reveal now emits ERC-4906's `BatchMetadataUpdate(startTokenId,
lastTokenId)`. The token advertises 4906, and `v2`'s extension already
emitted it.
- `setMaxSupply` now reverts `AlreadyRevealed()` after the reveal, which
also blocks it through `multiConfigure`. Raising it after the reveal
reshuffled revealed metadata. To allow the override, the base
`setMaxSupply` goes from `external` to `public virtual`. The ABI is the
same.

**2. Upgradeable random offset init.**
`__ERC721SeaDropRandomOffset_init` didn't run its parents' initializers.
That left no name, symbol or owner, and a zero reentrancy lock, so every
mint reverted. It now runs the full parent init.

**3. `multiConfigure` length checks** (`ERC721SeaDrop`,
`ERC721SeaDropCloneable`, `ERC721SeaDropUpgradeable`). The checks that
allowed tokens pair with token-gated stages, and signers with validation
params, only ran when the stages or... (continued)

172 of 250 branches covered (68.8%)

Branch coverage included in aggregate %.

40 of 40 new or added lines in 9 files covered. (100.0%)

1048 of 1366 relevant lines covered (76.72%)

2426.01 hits per line

Jobs
ID Job ID Ran Files Coverage
1 foundry - 42311051763.1 06 Nov 2026 11:19PM UTC 32
75.5
GitHub Action Run
Source Files on build 42311051763
  • Tree
  • List 32
  • Changed 9
  • Source Changed 9
  • Coverage Changed 8
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #42311051763
  • 691f0154 on github
  • Prev Build on main (#42309149829)
  • Next Build on main (#42313098123)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc