fyne-io / fyne / 42306223107

62%

Build Type

push

github

Committed by andydotxyz

Commit Message

Mark preferences as saved before opening the file

save opened the storage writer, which creates or truncates the file,
before it set savedRecently. The preferences' own file watch could see
that write first and load the empty or partly written file, logging
"Preferences load error:" with EOF. This shows at quit, where the save
in the stop hook and the watch callback run off the main thread once
its queue is drained.

Set savedRecently before the writer is opened, as secretPreferences
does. The test holds a read lock so that save waits where it marks
itself, then reads the file as the watch would.

Coverage Stats

5 of 5 new or added lines in 1 file covered. (100.0%)

5 existing lines in 1 file now uncovered.

26022 of 42264 relevant lines covered (61.57%)

16176.01 hits per line