FlexMeasures / flexmeasures / 42305793744

88%

push

github

Apply storage losses to a shared stock's starting stock in its stored state of charge (#2838)

* Test that a shared stock's stored SoC decays like the solver's stock

A shared stock (two flex-model entries on one state-of-charge sensor) with a storage efficiency below 1 should store the same decaying state of charge as a single-device stock,
and the stock the solver modelled, with and without flows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UBBvKZkzbfEPKctwTN8SDf
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* Apply storage losses to a shared stock's starting stock in its SoC schedule

The shared-stock branch of StorageScheduler._build_soc_schedule integrated each device's contribution from zero and added the starting stock on top,
so the starting stock never decayed, while the solver's group_stock_balance decays the whole stock.
Integrate the starting stock along with the first device's contribution instead,
and use the group's storage efficiency (that of its first device) for all contributions, as the solver does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UBBvKZkzbfEPKctwTN8SDf
Signed-off-by: F.N. Claessen <claessen@seita.nl>

---------

Signed-off-by: F.N. Claessen <claessen@seita.nl>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

1 of 1 new or added line in 1 file covered. (100.0%)

23212 of 26399 relevant lines covered (87.93%)

0.88 hits per line