clay / claycli / 42277631982

86%

master: 86%

Pull #285

github

🍕 prefixes: only the url of a page is the bare site when it is empty

Review feedback (Codex, P1): the rule "an empty string is the bare site" applied to every url and customUrl in a page dispatch, so an unset customUrl ('') became the site root on import, and a ?query or #fragment value anywhere in a page was moved onto the host. Sites reads a falsy customUrl as "no custom url", so that would have made one up.

Only the `url` of a page keeps the bare form now: https://host is exported as an empty string and an empty url comes back as https://host, which is what keeps grubstreet's and vulture's homepages at the form they are already published at. A customUrl that is the bare site is exported as /, an empty customUrl stays empty, and a ?query or #fragment right after the host is stripped like any other url (/?a=b) instead of getting a form of its own. No real page uses either: of the 37 staging pages the hydrate job imports, none has an empty url or customUrl.

1037 of 1302 branches covered (79.65%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 1 file covered. (100.0%)

2015 of 2263 relevant lines covered (89.04%)

29.31 hits per line