supabase / supabase / 42269096519

87%

push

github

feat(studio): review a pending network restrictions change (#52984)

## Problem

A network restrictions change that was never applied can now wait for
the customer's review ([API
Docs](https://api.supabase.com/api/v1#tag/projects/POST/v1/projects/{ref}/network-restrictions/review),
[CTRL-1934](https://linear.app/supabase/issue/CTRL-1934)). Studio
doesn't show it. Lists with an entry that isn't a valid IP range also
fail to save without saying which entry is wrong.

## Solution

- A change in review shows one callout with **Apply change** and
**Discard change**, and both lists together: added entries in green,
removed ones in red. Editing is disabled until it's resolved, and
discarding asks for confirmation. Only the change on screen is resolved
(`pending_requested_at`).
- A list the worker is still applying shows as applying and is polled,
instead of showing the "not applied correctly" error.
- Entries that aren't valid ranges are marked Invalid with a suggested
correction, and can be saved corrected. The add dialog rejects
IPv4-mapped IPv6 addresses and finds duplicates spelled differently.

There's no way to create a review yet: a change only ends up in review
when the backend fails to apply a list. I tested the review state
locally by editing the database directly.

Stacked on #53046, which syncs the API types with production, including
the review endpoint. This PR will be retargeted to `master` once that
merges.

## Screenshots

<img width="712" height="473" alt="Screenshot 2026-11-04 at 5 10 19 PM"
src="https://github.com/user-attachments/assets/c72cc38d-f7b4-4269-a787-f27dfe382086"
/>

### If pressing `apply`

<img width="704" height="150" alt="Screenshot 2026-11-04 at 5 19 27 PM"
src="https://github.com/user-attachments/assets/92dce8e5-8d58-48b8-8899-ed01c9f242c2"
/>

### If pressing `discard`

<img width="712" height="473" alt="Screenshot 2026-11-04 at 5 10 38 PM"
src="https://github.com/user-attachments/assets/85656004-d510-4cef-89c1-80d9f95e... (continued)

2048 of 2417 branches covered (84.73%)

Branch coverage included in aggregate %.

2845 of 3205 relevant lines covered (88.77%)

201.46 hits per line