firebase / firebase-js-sdk / 42261628534

84%

master: 0%

push

github

fix(ai): don't let a later `getAI()` call overwrite an existing instance's options (#10554)

* fix(ai): do not let a later getAI() call overwrite an existing instance's options

AI instances are cached per app and backend, but getAI() unconditionally
reassigned the instance's options on every call. A plain getAI(app) call
anywhere in the app therefore reset useLimitedUseAppCheckTokens to false on
an instance that had opted in, and every model created afterwards from that
instance sent standard (cached, replayable) App Check tokens instead of
limited-use tokens.

getAI() now only assigns options when it creates the instance. Later calls
for the same app and backend return the existing instance unchanged if they
omit useLimitedUseAppCheckTokens or pass the same value, and throw an
AIError with the new code `already-initialized` if they pass a different
value, mirroring initializeAppCheck().

460 of 603 branches covered (76.29%)

Branch coverage included in aggregate %.

1240 of 1418 relevant lines covered (87.45%)

55.26 hits per line