• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tari-project / tari / 42227896382
79%

Build:
DEFAULT BRANCH: development
Ran 06 Nov 2026 03:43PM UTC
Jobs 1
Files 801
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

06 Nov 2026 01:44PM UTC coverage: 78.272% (+0.07%) from 78.2%
42227896382

push

github

web-flow
fix(mempool): remove the unused get_state method from the peer mempool RPC (#8265)

Description
---
Removes the `get_state` method (method id 2) from the peer mempool RPC
(`t/mempool/1`), along with the code that only served it:
- `MempoolHandle::get_state`
- the `StateResponse` proto message and its conversions
- the matching mock setter and test

The protocol name stays `t/mempool/1`. Methods 1, 3 and 4 keep their
ids, and a comment on the trait says id 2 is retired and must not be
reused.

The local paths are unchanged: the CLI `get-mempool-state` and gRPC
`GetMempoolTransactions` still return the full pool through
`LocalMempoolService::get_mempool_state`.

Motivation and Context
---
`get_state` built and encoded the whole mempool for any peer on every
call, and a response larger than the RPC frame limit failed only after
all that work. Nothing calls it: `MempoolRpcClient` has no user in this
repo or in the related client repos.

How Has This Been Tested?
---
- New test
`mempool::rpc::test::retired_get_state::method_2_is_unsupported_and_the_session_stays_usable`.
It calls method 2 on a real RPC session, gets `UnsupportedMethod`, then
calls `get_stats` on the same session and checks the result.
- `cargo ci-test`, `cargo ci-check`, `cargo ci-clippy`, fmt, `cargo test
-p tari_core --lib mempool`, `cargo test -p minotari_node` and
`scripts/decoder_parity_check.py` all pass.
- One decode-budget test that only exercised the removed proto message
was deleted. The general sibling and nested flood cases are still
covered by `comms/core/src/decode_budget.rs`.

What process can a PR reviewer use to test or verify this change?
---
- Run `cargo test -p tari_core --lib mempool::rpc`.
- Grep for `get_state` and `StateResponse` under
`base_layer/core/src/mempool`. Only the local path
(`MempoolRequest::GetState`, `LocalMempoolService::get_mempool_state`)
and the native `StateResponse` should remain.

Breaking Changes
---

- [x] None
- [ ] Requires data directory on... (continued)

35 of 40 new or added lines in 2 files covered. (87.5%)

138 existing lines in 17 files now uncovered.

146806 of 187559 relevant lines covered (78.27%)

1092795.06 hits per line

Uncovered Changes

Lines Coverage ∆ File
4
89.55
-6.22% base_layer/core/src/mempool/test_utils/mock.rs
1
99.15
-0.85% base_layer/core/src/mempool/rpc/test.rs

Coverage Regressions

Lines Coverage ∆ File
94
67.07
0.92% base_layer/core/src/chain_storage/blockchain_database.rs
7
77.4
-0.09% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
6
78.51
0.83% comms/core/src/connectivity/manager.rs
6
92.42
-1.23% comms/dht/src/outbound/broadcast.rs
4
73.08
-0.07% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
3
78.49
-3.23% base_layer/core/src/validation/mocks.rs
3
81.25
-4.69% comms/core/src/pipeline/outbound.rs
3
80.66
-0.31% comms/dht/src/connectivity/mod.rs
2
83.79
-0.19% base_layer/wallet/src/storage/sqlite_db/wallet.rs
2
86.47
0.29% comms/core/src/protocol/rpc/client/mod.rs
2
87.04
-0.46% comms/dht/src/network_discovery/rebootstrap.rs
1
94.96
0.15% base_layer/core/src/base_node/sync/horizon_state_sync/synchronizer.rs
1
86.99
-0.23% base_layer/core/src/mempool/service/service.rs
1
75.72
-0.22% base_layer/core/src/mempool/sync_protocol/mod.rs
1
88.85
-0.17% comms/core/src/connection_manager/dialer.rs
1
49.06
-0.94% comms/core/src/connectivity/selection.rs
1
92.71
0.39% comms/core/src/multiplexing/yamux.rs
Jobs
ID Job ID Ran Files Coverage
1 42227896382.1 06 Nov 2026 03:43PM UTC 801
78.27
GitHub Action Run
Source Files on build 42227896382
  • Tree
  • List 801
  • Changed 32
  • Source Changed 5
  • Coverage Changed 32
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #42227896382
  • 61b8a72d on github
  • Prev Build on development (#42211089709)
  • Next Build on development (#42575445992)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc