zopefoundation / AccessControl / 42187402787

82%

master: 83%

Build Type

Pull #178

github

Committed by jensens

Commit Message

Store new values before releasing old ones in SecurityManager_setattro

ASSIGN released the old context, policy or thread id before storing
the new one, and the _policy branch released the cached bound policy
methods before clearing the fields.  Code that runs while the old
object is torn down, for example a __del__, could reach the dying
object through the manager.  Use Py_XSETREF and Py_CLEAR, which store
first and release afterwards.

Assisted-by: Claude Fable 5.1

Pull Request Pull Request #178: Let the C SecurityManager take part in garbage collection

Coverage Stats

734 of 1240 branches covered (59.19%)

Branch coverage included in aggregate %.

140 of 140 new or added lines in 1 file covered. (100.0%)

14 existing lines in 1 file now uncovered.

5654 of 6506 relevant lines covered (86.9%)

0.87 hits per line