ponder-lab / Hybridize-Functions-Refactoring / #4060

90%

push

github

Refuse layer building only where it changes behavior (#1246)

* Refuse layer building only where it changes behavior

Calling sublayers built in __init__ or build on every call is safe under
tf.function, yet any method reaching add_weight was refused. Now a method is
refused only when its trace constructs a layer, may first call one under a
condition the engine doesn't show fixed, or reaches sublayer names that may
collide (#1224).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Refuse a layer call whose callee data may choose on a retrace

A call such as (self.a if flag else self.b)(x) sits under no branch, yet a
retrace with another flag builds the other layer. A callee that may be more
than one layer is now refused unless a phi merges them under fixed branches.
The f-string TODO now names wala/ML#1231.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Refuse when a layer's allocation can't be placed

A sublayer or a callee layer whose allocation the engine doesn't place
can't be told apart from the others or have its name read, so the method
is refused rather than the analysis failing on it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Close review misses in the layer-build refusal

A condition that is a tensor in one call and a Python value in another
now varies, and a call in a reachable exception handler, a layer chosen by
a varying index, an f-string name and a ** name now refuse. An allocation
whose object the engine doesn't name refuses as a construction.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Read a name forwarded through an __init__'s own **kwargs

super().__init__(**kwargs) forwards only the keywords... (continued)

409 of 443 new or added lines in 4 files covered. (92.33%)

6540 of 7290 relevant lines covered (89.71%)

0.9 hits per line