shakefu / pyconfig / 42148465345

78%

Build Type

push

github

Committed by shakefu

Commit Message

fix(etcd): harden the etcd3 integration

- Catch non-ImportError failures importing etcd3 (e.g. TypeError with
  protobuf >= 4) and disable etcd support with a warning, instead of
  crashing the first pyconfig.get() even when etcd isn't configured.
- Keep PYCONFIG_ETCD_AUTH working without TLS: gRPC refuses to send call
  credentials over a plaintext channel, so drop them and rely on the
  token metadata etcd3 also sends.
- Reconnect and retry once when etcd rejects an expired auth token;
  etcd3 never refreshes the token it gets at client creation.
- Warn when TLS is requested via a client cert/key or https protocol
  without a CA cert, since etcd3 then silently connects in plaintext.
- Only load (and watch) keys directly under the prefix, matching the v2
  non-recursive get, and strip the prefix before lower-casing keys.
- Warn on incomplete PYCONFIG_ETCD_AUTH credentials.
- Document the protobuf constraint and TLS/auth behavior in the README.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

38 of 41 new or added lines in 1 file covered. (92.68%)

41 existing lines in 1 file now uncovered.

471 of 607 relevant lines covered (77.59%)

3.1 hits per line