Giorgi / DuckDB.NET / 42114730287

94%

Build Type

push

github

Committed by Giorgi

Commit Message

Store a DateTime appended to a TIME column as its time of day

A DateTime appended to a TIME column, in a row or as a list item, stored
the microseconds of the whole timestamp from 1970, far more than a day,
which no one could have used. It now stores the time of day, through the
same ToDuckDBTime a TIME parameter uses; a TIME_NS column already did.

The writer of the timestamps serves TIME too, so this is one more test of
the column type for every DateTime written, next to the one for DATE. It
is not measured; the time readers and writers in classes of their own
(2.0 perf audit, item 11) would remove it.

DateTimeAppendedToATimeIsItsTimeOfDay compares with DuckDB's own cast of
the same moment to TIME, before 1970 and at both ends of DateTime too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LUiK1sJNRH6KnBAFcQsGLc

Coverage Stats

2774 of 3021 branches covered (91.82%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

4321 of 4578 relevant lines covered (94.39%)

1057063.73 hits per line