IntelPython / dpnp / 42077609574

84%

push

github

Pass depends to the `_place` call in `dpnp.tensor.place` (#3164)

`dpnp.tensor.place` casts `vals` to the array's data type with
`dpt.astype`, which is asynchronous, and then called `ti._place` without
`depends`. The kernel could start before the cast finished and write
values from an incomplete buffer into the array. `dpnp.place` goes
through the same path.

The `mask_positions` call earlier in the function is synchronous, so
only the cast was unordered. This PR passes
`depends=_manager.submitted_events` to `ti._place`.

The race is timing-dependent, so no test is added. On an out-of-order
queue of an Intel CPU (OpenCL), `place` of an `int32` `vals` into a
`float32` array, with the cast held back behind a few large copies, gave
wrong values in 9 of 10 runs before this change and in 0 of 10 after. On
a Level Zero iGPU it did not reproduce either way.

1792 of 2998 branches covered (59.77%)

Branch coverage included in aggregate %.

29615 of 34216 relevant lines covered (86.55%)

39131.68 hits per line