• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubernetes-sigs / inference-perf / 42088289944
87%

Build:
DEFAULT BRANCH: main
Ran 05 Nov 2026 07:02PM UTC
Jobs 1
Files 137
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

05 Nov 2026 06:51PM UTC coverage: 85.725% (+0.03%) from 85.694%
42088289944

push

github

web-flow
Fix duplicate .zst trace loading and make zstd import lazy (#1008)

Fixes #925

**Old behavior:** a `trace_directory` (or a `trace_files` glob) holding
both `a.json` and `a.json.zst` loaded both, so every trace replayed
twice with no warning. `wire_trace_converter` also imported zstd at
module load, and `inference_perf.datagen` imports every replay
generator, so an interpreter without `compression.zstd` failed every
workload, not only OTel replay.

**New behavior:** the `.zst` is skipped with a warning when its
uncompressed twin is also listed (the uncompressed copy is kept because
OTel `.jsonl` cannot be read compressed). zstd is imported on first use,
so `inference_perf.datagen` imports without it.

Changes:
- `drop_compressed_duplicates` in `wire_trace_converter.py`, applied to
both the `trace_directory` and `trace_files` paths.
- `_zstd()` lazy import; `TRACE_READ_ERRORS` becomes
`trace_read_errors()`, which omits `ZstdError` when zstd is missing.
Call sites in `trace_source.py` updated.
- Three tests in `tests/test_local_trace_source.py`: directory with
twin, glob with twin, and import with zstd blocked in a fresh
interpreter.

**Failing on main before the fix:**
```
E       assert 2 == 1
E        +  where 2 = len([None, None])   # directory and glob tests
E       ModuleNotFoundError: import of backports halted; None in sys.modules
        File ".../datagen/replay/wire_trace_converter.py", line 48, in <module>
          from backports import zstd
```

**Not run:** `pdm run validate` and `pdm run test:e2e` (no pdm or
`llm-d-inference-sim` here; `llmd-benchmark-report` was not installable,
so `tests/reportgen` was skipped). ruff is clean and mypy reports
nothing for the touched files. `tests/` otherwise ran with 24 failures,
all in integration, sim, mutation-script and reportgen tests that need
those tools.

26 of 33 new or added lines in 3 files covered. (78.79%)

13242 of 15447 relevant lines covered (85.73%)

0.86 hits per line

Uncovered Changes

Lines Coverage ∆ File
5
84.63
-0.14% inference_perf/datagen/replay/wire_trace_converter.py
2
91.54
1.0% inference_perf/datagen/replay/trace_source.py
Jobs
ID Job ID Ran Files Coverage
1 42088289944.1 05 Nov 2026 07:02PM UTC 137
85.73
GitHub Action Run
Source Files on build 42088289944
  • Tree
  • List 137
  • Changed 3
  • Source Changed 3
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #42088289944
  • bb11e25b on github
  • Prev Build on main (#41889509256)
  • Next Build on main (#42093717096)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc