Mellanox / spectrum-x-operator / 42066713889-1

54%

main: 54%

Build Type

push

github

Committed by rollandf

Commit Message

fix: set global plane ID in xplane-plane-id external_id

createXPlaneBridges wrote the PF's index within its rail (0..N-1) to
external_ids:xplane-plane-id, which is the key XPlane reads, and wrote
the global plane ID (len(PfNames)*SwPlane + idx) to a separate
plane_id key that nothing reads.

As a result, uplinks on different software planes told XPlane they
were the same plane. For example, eth_r1_p4 (plane 4) reported plane 0.
When a switch port went down, the Flush updates from that uplink
cleared the remote failure entry that the real plane-0 uplink kept
advertising in Periodic updates, so remoteTotal flapped on every node.

Write the global plane ID to xplane-plane-id and remove the unused
plane_id key. Update the unit test to check xplane-plane-id.

Fixes: https://redmine.nvidia.com/issues/5374178

Signed-off-by: Fred Rolland <frolland@nvidia.com>

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

1008 of 1857 relevant lines covered (54.28%)

0.54 hits per line