safe-global / safe-eth-py / 42062861621

94%

push

github

fix: raise TraceNotFound when the node has no traces for a tx (#2829)

Nodes (Erigon, anvil) return `null` for `trace_transaction` on a tx they
do not know. web3 then fails with `TypeError: NoneType takes no arguments`
when it formats the result.

`trace_transaction(s)` (sync and async) now raise `TraceNotFound`. It is an
`EthereumClientException` and also web3's `TransactionNotFound`, so callers
that already catch `ValueError` or `Web3RPCError` for node errors handle it.
A batch with one unknown tx fails as a whole, as before, so an indexer
retries instead of skipping the tx.

`trace_block` is not changed: nodes return an error for an unknown block,
not `null`.

21 of 21 new or added lines in 4 files covered. (100.0%)

11784 of 12554 relevant lines covered (93.87%)

3.49 hits per line