penguinolog / urwid / 42061735516

94%

push

github

Add OverlayStack: nested dialogs over a base widget (#1592)

* Add OverlayStack for nested dialogs

A box widget that keeps a base widget and a stack of dialogs, each an Overlay over the one below.

- open() takes the Overlay layout options; width and height default from the dialog's sizing.
- close() closes the top dialog, or a given dialog and every dialog above it, with a result.
- close_on_menu and close_on_click_outside close a dialog on Esc or an outside press, per stack or per dialog.
- on_close callbacks and the "closed" signal run after the dialog is removed.
- The overlays hold the stack weakly, so a dropped stack is freed with dialogs open.

* Convert the cmenu tutorial to OverlayStack

The cascading menu now opens its boxes with OverlayStack.open() instead of a hand-built WidgetPlaceholder subclass.

- The Overlay parameters are unchanged, so cmenu1.png to cmenu4.png stay valid.
- Every box after the first closes on Esc or a click outside; the main menu stays open.

* Add OverlayStack to the container widgets diagram

The diagram now has the width of the basic widgets diagram, with an extra row.

- OverlayStack follows Overlay in the container widgets.
- Scroll, pop-up and special widgets move down to keep the 832 px width.

* Count the watch_pipe test timers from the awaited event

Three watch_pipe tests stopped the loop on alarms counted from before run().
On a slow start every alarm is due on the first pass, so the loop stopped before the pipe was read.

- Each stop timer now starts from the read or callback the test waits for.
- A 5 s guard alarm ends a run in which that event never comes.
- The second write of the read-once test is counted from the first read, so the two never merge.

* Expect the OverlayStack leak test to fail on free-threaded 3.13

Overlay.contents defines a class on every access, and the free-threaded CPython 3.13 build makes every class
immortal once a thread has started, so that class keeps each Overlay alive.
Th... (continued)

6618 of 7304 branches covered (90.61%)

Branch coverage included in aggregate %.

124 of 124 new or added lines in 5 files covered. (100.0%)

16982 of 18050 relevant lines covered (94.08%)

14.9 hits per line