• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubernetes-sigs / lws / 42048114597
88%

Build:
DEFAULT BRANCH: main
Ran 05 Nov 2026 02:52PM UTC
Jobs 1
Files 41
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

05 Nov 2026 02:45PM UTC coverage: 88.007% (+0.1%) from 87.875%
42048114597

push

github

web-flow
Add spec.placementPolicy for exclusive topology placement (#1165)

* Add spec.placementPolicy for exclusive topology placement

Implements KEP-1064: a top-level spec.placementPolicy as the typed
replacement for the exclusive-topology and subgroup-exclusive-topology
annotations, with replica-level placement on the policy itself and
subgroup-level placement in spec.placementPolicy.subGroup. The types
are PlacementPolicy, SubGroupPlacementPolicy and PlacementType.

The revision records the effective placement, the field first and the
annotation second, so moving a value between them keeps the revision,
and a placement change rolls out under maxUnavailable and maxSurge.
Revisions created before this change keep the live field and
annotations when restored. The worker StatefulSet takes its topology
keys from the group's leader pod.

Admission validates the topology keys, requires subgroups for subgroup
placement, and requires the two levels to use different keys after
resolving each level from the field or its annotation. A field and an
annotation of the same level must agree, and annotations get a
deprecation warning. KEP-666 rule 10 stays at the replica level.
DisaggregatedSet validatePlacement rejects a role's placement only when
it uses the DisaggregatedSet topology key.

* Use revisionRecordsPlacement in ApplyRevision

* KEP-1064: note that annotation-only objects skip the key check

* Track annotation placement in the revision match cache

Exclusive-topology annotations are recorded in the revision but do not
bump the generation, so a cached match keyed on generation could hide an
annotation change. Add the proposed revision key to the cache key.

ApplyRevision now clears a live spec.placementPolicy whenever the
revision data has none, including revisions created before placement was
recorded, since the field did not exist then.

* KEP-1064: mark implementable and target alpha in v1.1

* Re-record pre-upgrade revisions with placement

A revision crea... (continued)

274 of 289 new or added lines in 9 files covered. (94.81%)

2 existing lines in 1 file now uncovered.

10582 of 12024 relevant lines covered (88.01%)

32278.44 hits per line

Uncovered Changes

Lines Coverage ∆ File
9
85.04
-0.49% pkg/controllers/leaderworkerset_controller.go
3
82.58
-0.56% pkg/controllers/leaderworkerset_hash.go
3
89.94
0.51% pkg/utils/revision/revision_utils.go

Coverage Regressions

Lines Coverage ∆ File
2
89.94
0.51% pkg/utils/revision/revision_utils.go
Jobs
ID Job ID Ran Files Coverage
1 42048114597.1 05 Nov 2026 02:52PM UTC 41
88.01
GitHub Action Run
Source Files on build 42048114597
  • Tree
  • List 41
  • Changed 9
  • Source Changed 0
  • Coverage Changed 9
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 9382aa3e on github
  • Prev Build on main (#41999793591)
  • Next Build on main (#42056222703)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc