FlexMeasures / flexmeasures / 42025884111

88%

push

github

Merge commit from fork

* check read permission for kpi sensors in relevant asset GET and PATCH endpoints

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* api/v3_0/assets: answer invalid KPI input on POST with a 422, not a 500

POST /api/v3_0/assets let the ValidationError from the KPI check escape, where PATCH catches it.
The errors now also name the field, sensors_to_show_as_kpis.
Tests cover the POST path: another organisation's sensor gets a 403, and invalid entries get a 422.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DWv6v5ELzmj2eBM1L4GTBz
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* data/services/generic_assets: drop the local import of check_access

The module imports it at the top now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DWv6v5ELzmj2eBM1L4GTBz
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* tests: explain what each assertion in the KPI access tests is for

Also say where the window's 91.3 comes from.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DWv6v5ELzmj2eBM1L4GTBz
Signed-off-by: F.N. Claessen <claessen@seita.nl>

---------

Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: F.N. Claessen <claessen@seita.nl>
Co-authored-by: F.N. Claessen <claessen@seita.nl>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

33 of 35 new or added lines in 2 files covered. (94.29%)

23159 of 26397 relevant lines covered (87.73%)

0.88 hits per line