tomaj / hermes / 42014810866

99%

push

github

6.0 review: handler result before stop, lost-retry log, priority validation, docs

Dispatcher
- A driver that uses ShutdownTrait gets the handler result also when a
  shutdown or signal was requested during the message, and stops at its
  own checkShutdown(). 5.x threw ShutdownException from the callback
  after the message, so a driver that records the result (e.g. a
  failed-task table) lost it on every stop. Any other driver, also one
  with its own setShutdown() that may never check SignalStop, still gets
  the exception after the message.
- A failed send() of a retry copy is logged as "Retry of message #<id>
  (<type>) lost - driver send failed: ..." and rethrown, so ack-after
  drivers still redeliver the original message.
- handle() casts integer strings ('110' from argv, also '050' and '-5')
  to int and rejects anything else ('high', '', '1.9', floats) with
  InvalidArgumentException; the drivers compare priorities strictly and
  a string ended the worker with a TypeError.

Docs (en, sk), README, UPGRADE-6.0, CHANGELOG
- Signal handling for custom drivers without checkShutdown() and for a
  while (true) loop around handle(); setMaxProcessItems() on RabbitMQ.
- README: when handle() returns, logger injection only by Dispatcher,
  delivery guarantee per driver, executeAt example.
- Stale 5.x statements removed from the guides and examples.
- BufferedEmitter: leftovers after a failed flush() are overtaken by the
  next non-transactional emit and dropped by the next rollback.

34 of 34 new or added lines in 1 file covered. (100.0%)

722 of 727 relevant lines covered (99.31%)

24.23 hits per line