• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

supabase / supabase-py / 42007162660
99%
main: 98%

Build:
Build:
LAST BUILD BRANCH: release-please--branches--main
DEFAULT BRANCH: main
Ran 05 Nov 2026 10:01AM UTC
Jobs 30
Files 189
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

05 Nov 2026 10:01AM UTC coverage: 99.037% (+0.001%) from 99.036%
42007162660

push

github

web-flow
fix(storage): reject invalid escapes and dot segments in object keys (#1988)

Follow-up to #1986. The same change for `main` is in #1987.

## Problem

#1986 percent-decodes each segment of an object key with
`urllib.parse.unquote()`. Its default `errors="replace"` turns an
invalid UTF-8 escape into U+FFFD, so `report%FF.txt` and `report%FE.txt`
both become `report�.txt`. Two different names are then sent as the same
key, and with `upsert` one upload can overwrite the other object. The
`yarl` parsing used before #1986 kept such escapes as they were, so this
collision is new in #1986.

A segment that decodes to `.` or `..` is also a problem. `joinpath()`
normalizes dot segments, so `folder?/../report.txt` targets
`report.txt`, and `../../auth` leaves the storage path entirely. The
`yarl` parsing before #1986 normalized `folder/../report.txt` the same
way, and #1986 now keeps keys such as `folder?/../report.txt` intact
past the `?`, so they reach the same normalization.

## Fix

Decode the whole key before splitting it on `/`, so the parts match the
segments `joinpath()` actually sends, including ones behind an encoded
slash such as `..%2Freport.txt`. Raise `ValueError` for any segment that
is `.` or `..`, including escaped ones like `%2E%2E`. Decode with
`errors="strict"`. A key with an invalid escape now raises
`UnicodeDecodeError` before any request is sent. Valid escapes such as
`a%20b.png` decode as before.

## Tests

`tests/test_object_paths.py` checks that uploads with an invalid escape
or a dot segment raise for both clients, and that `get_public_url()`
rejects dot segments.

From `src/storage`:

- `uv run --frozen --package storage3 pytest -o addopts=""
tests/test_object_paths.py tests/test_upload_headers.py
tests/test_utils.py tests/test_client.py`: 142 passed.
- `uv run --frozen --package storage3 --group mypy mypy src/storage3
tests`: no issues.
- `ruff format` and `ruff check`: passed.

15836 of 15990 relevant lines covered (99.04%)

5.13 hits per line

Coverage Regressions

Lines Coverage ∆ File
3
98.54
0.02% src/storage3/_sync/file_api.py
3
98.54
0.02% src/storage3/_async/file_api.py
Jobs
ID Job ID Ran Files Coverage
1 run-ubuntu-latest-3.14-supabase - 42007162660.1 05 Nov 2026 10:01AM UTC 22
97.92
GitHub Action Run
2 run-ubuntu-latest-3.14-functions - 42007162660.2 05 Nov 2026 10:01AM UTC 18
97.98
GitHub Action Run
3 run-ubuntu-latest-3.12-supabase - 42007162660.3 05 Nov 2026 10:01AM UTC 22
97.93
GitHub Action Run
4 run-ubuntu-latest-3.14-storage - 42007162660.4 05 Nov 2026 10:02AM UTC 45
98.56
GitHub Action Run
5 run-ubuntu-latest-3.15-realtime - 42007162660.5 05 Nov 2026 10:03AM UTC 17
97.73
GitHub Action Run
6 run-ubuntu-latest-3.14-auth - 42007162660.6 05 Nov 2026 10:02AM UTC 68
98.83
GitHub Action Run
7 run-ubuntu-latest-3.13-auth - 42007162660.7 05 Nov 2026 10:02AM UTC 68
98.83
GitHub Action Run
8 run-ubuntu-latest-3.11-auth - 42007162660.8 05 Nov 2026 10:02AM UTC 68
98.83
GitHub Action Run
9 run-ubuntu-latest-3.15-auth - 42007162660.9 05 Nov 2026 10:02AM UTC 68
98.83
GitHub Action Run
10 run-ubuntu-latest-3.12-realtime - 42007162660.10 05 Nov 2026 10:02AM UTC 17
97.86
GitHub Action Run
11 run-ubuntu-latest-3.15-supabase - 42007162660.11 05 Nov 2026 10:01AM UTC 22
97.92
GitHub Action Run
12 run-ubuntu-latest-3.13-functions - 42007162660.12 05 Nov 2026 10:01AM UTC 18
97.98
GitHub Action Run
13 run-ubuntu-latest-3.14-postgrest - 42007162660.13 05 Nov 2026 10:02AM UTC 42
99.57
GitHub Action Run
14 run-ubuntu-latest-3.13-supabase - 42007162660.14 05 Nov 2026 10:01AM UTC 22
97.93
GitHub Action Run
15 run-ubuntu-latest-3.11-realtime - 42007162660.15 05 Nov 2026 10:02AM UTC 17
97.86
GitHub Action Run
16 run-ubuntu-latest-3.12-storage - 42007162660.16 05 Nov 2026 10:02AM UTC 45
98.56
GitHub Action Run
17 run-ubuntu-latest-3.11-functions - 42007162660.17 05 Nov 2026 10:01AM UTC 18
97.98
GitHub Action Run
18 run-ubuntu-latest-3.12-auth - 42007162660.18 05 Nov 2026 10:02AM UTC 68
98.83
GitHub Action Run
19 run-ubuntu-latest-3.11-storage - 42007162660.19 05 Nov 2026 10:02AM UTC 45
98.56
GitHub Action Run
20 run-ubuntu-latest-3.15-storage - 42007162660.20 05 Nov 2026 10:03AM UTC 45
98.56
GitHub Action Run
21 run-ubuntu-latest-3.15-functions - 42007162660.21 05 Nov 2026 10:01AM UTC 18
97.98
GitHub Action Run
22 run-ubuntu-latest-3.12-postgrest - 42007162660.22 05 Nov 2026 10:02AM UTC 42
99.58
GitHub Action Run
23 run-ubuntu-latest-3.14-realtime - 42007162660.23 05 Nov 2026 10:02AM UTC 17
97.73
GitHub Action Run
24 run-ubuntu-latest-3.13-storage - 42007162660.24 05 Nov 2026 10:02AM UTC 45
98.56
GitHub Action Run
25 run-ubuntu-latest-3.12-functions - 42007162660.25 05 Nov 2026 10:01AM UTC 18
97.98
GitHub Action Run
26 run-ubuntu-latest-3.15-postgrest - 42007162660.26 05 Nov 2026 10:02AM UTC 42
99.57
GitHub Action Run
27 run-ubuntu-latest-3.11-supabase - 42007162660.27 05 Nov 2026 10:01AM UTC 22
97.93
GitHub Action Run
28 run-ubuntu-latest-3.13-realtime - 42007162660.28 05 Nov 2026 10:02AM UTC 17
97.86
GitHub Action Run
29 run-ubuntu-latest-3.11-postgrest - 42007162660.29 05 Nov 2026 10:02AM UTC 42
99.58
GitHub Action Run
30 run-ubuntu-latest-3.13-postgrest - 42007162660.30 05 Nov 2026 10:02AM UTC 42
99.58
GitHub Action Run
Source Files on build 42007162660
  • Tree
  • List 189
  • Changed 3
  • Source Changed 0
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #42007162660
  • a308cdea on github
  • Prev Build on v2 (#42002724346)
  • Next Build on v2 (#42241873590)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc