kubernetes-sigs / external-dns / 41991857837
83%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 168
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.332% (+0.04%) from 83.294%
41991857837

push

github

web-flow 
fix(rfc2136): surface record build errors and skip partial updates in ApplyChanges (#6868)

* refactor(rfc2136): reduce ApplyChanges cyclomatic complexity

Signed-off-by: Martin Montes <martin11lrx@gmail.com>

* refactor(rfc2136): collapse apply*Batches into a single applyBatches

Address review comments:
- collapse applyCreateBatches/applyUpdateBatches/applyDeleteBatches into
  one applyBatches(action, eps, apply) helper, with the update closure
  indexing changes.UpdateOld[idx]
- test stub now counts SendMessage calls and the all-filtered test
  asserts a zero count and covers the update path (UpdateOld/UpdateNew)
- drop doc comments that restate the helper names

Signed-off-by: Martin Montes <martin11lrx@gmail.com>

* refactor(rfc2136): build batch updates in a scratch message

Address review comments:
- build each endpoint into a scratch message and merge it into the
  batch only on success, so a failed endpoint (e.g. an invalid TXT
  target) no longer leaves a partial update behind; wrap the error
  with the endpoint's DNS name
- drop the root-zone comment and shorten the idx comment
- new test with an invalid TXT target on UpdateNew asserts the error
  is a SoftError naming the endpoint and that nothing is sent

Signed-off-by: Martin Montes <martin11lrx@gmail.com>

* refactor(rfc2136): address review comments on error wrapping and batch setup

Address review comments:
- join the batch errors with errors.Join and wrap them with %w so the
  soft error keeps the inner causes recoverable via errors.Is
- call SetUpdate once per zone per batch instead of once per endpoint
- inline the one-use acceptsEndpoint helper back into the batch loop

Signed-off-by: Martin Montes <martin11lrx@gmail.com>

---------

Signed-off-by: Martin Montes <martin11lrx@gmail.com>

16413 of 19696 relevant lines covered (83.33%)

1474.99 hits per line

Coverage Regressions

Lines Coverage ∆ File
50
80.45
1.65% rfc2136/rfc2136.go
1
87.27
-0.91% openshift_route.go
Jobs
ID Job ID Ran Files Coverage
1 run-ubuntu-latest - 41991857837.1 168
83.33
GitHub Action Run
2 run-macos-latest - 41991857837.2 168
83.33
GitHub Action Run
Source Files on build 41991857837