cameri / nats-server / 41969530569
78%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 66
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.663% (-1.1%) from 82.777%
41969530569

push

github

web-flow 
[FIXED] Remove stale JetStream account usage after peer removal (#8570)

Fixes #8563.

When a JetStream server is permanently removed from the cluster, its
last reported account usage can remain in `jsAccount.rusage`. Because
that value is still included in the account totals, replacing a stream
replica on another server can cause storage usage to be counted twice.

I reproduced this with a 4-node cluster and an R3 stream. After removing
one of the replica-holding servers and letting the stream move to the
spare node, the stream was still correctly running with 3 replicas, but
the account storage usage increased as if there were 4 copies.

This change removes the departed server's usage when its meta peer
removal is committed. It also ignores a late usage update from the
removed node so that the stale entry cannot be added back after cleanup.

I added a regression test that:

* creates an R3 stream on a 4-node cluster,
* verifies the initial account usage,
* removes one of the servers hosting a replica,
* waits for the replica to move to the spare server,
* verifies the account usage stays unchanged,
* and checks that a late usage update from the removed peer does not
recreate the stale entry.

Testing:

* new regression test passes repeatedly
* regression test passes with `-race`
* related peer-removal and account-usage tests pass
* `go vet ./server`
* `git diff --check`

70584 of 86433 relevant lines covered (81.66%)

331421.49 hits per line

Coverage Regressions

Lines Coverage ∆ File
581
63.9
-13.77% src/github.com/nats-io/nats-server/server/opts.go
234
78.23
-5.8% src/github.com/nats-io/nats-server/server/raft.go
54
83.85
-7.27% src/github.com/nats-io/nats-server/server/parser.go
39
83.04
-0.2% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
28
88.45
-1.02% src/github.com/nats-io/nats-server/server/server.go
20
92.57
-0.39% src/github.com/nats-io/nats-server/server/client.go
15
81.24
0.14% src/github.com/nats-io/nats-server/server/memstore.go
14
87.82
0.33% src/github.com/nats-io/nats-server/server/consumer.go
12
10.38
-11.32% src/github.com/nats-io/nats-server/server/signal.go
11
84.4
-0.42% src/github.com/nats-io/nats-server/server/route.go
9
85.93
-0.29% src/github.com/nats-io/nats-server/server/accounts.go
9
86.65
-0.76% src/github.com/nats-io/nats-server/server/auth.go
9
89.19
-0.38% src/github.com/nats-io/nats-server/server/leafnode.go
9
72.96
-5.66% src/github.com/nats-io/nats-server/server/log.go
8
78.16
-0.03% src/github.com/nats-io/nats-server/server/filestore.go
8
74.42
-4.65% src/github.com/nats-io/nats-server/server/jwt.go
8
86.48
-0.22% src/github.com/nats-io/nats-server/server/monitor.go
7
73.93
0.05% src/github.com/nats-io/nats-server/server/jetstream_api.go
5
89.7
-1.07% src/github.com/nats-io/nats-server/server/msgtrace.go
5
86.13
-0.02% src/github.com/nats-io/nats-server/server/stream.go
3
85.02
-0.15% src/github.com/nats-io/nats-server/server/events.go
2
93.47
-0.05% src/github.com/nats-io/nats-server/server/gateway.go
2
55.36
-0.14% src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
2
84.49
-0.1% src/github.com/nats-io/nats-server/server/jetstream.go
1
76.56
-1.56% src/github.com/nats-io/nats-server/server/errors.go
1
88.53
-0.03% src/github.com/nats-io/nats-server/server/mqtt.go
Jobs
ID Job ID Ran Files Coverage
1 41969530569.1 66
81.66
GitHub Action Run
Source Files on build 41969530569