sds / overcommit / 41960837614

92%

master: 91%

push

github

Re-enable the full Windows test matrix and fix platform failures (#911)

Windows CI has been disabled since #836. Restore the full test matrix on
Windows for every supported Ruby (2.6–4.0), alongside Linux, and remove
the Windows and AppVeyor exclusions from the specs. Give the slower
Windows jobs 30 minutes to complete the integration suite while
retaining the 15-minute Linux limit. Both platforms now run the same
1,679 examples; no examples are removed or newly skipped.

The restored matrix exposed two production failures:

- Reading merge state with `File.open(...).read` leaves handles open
until garbage collection, preventing Windows from deleting `MERGE_MODE`.
Use `File.read` so the handles close immediately. Also close readers and
temporary files in the Gerrit specs, and retain commit-message fixtures
until each example finishes, to prevent Windows finalizer errors.
- Parent-command detection depends on WMIC, which is unavailable on
current Windows runners. Query `Win32_Process` through PowerShell's
`Get-CimInstance`, preserving the `nil` fallback when the command cannot
launch or the parent has exited.

Use Ruby's native symlink APIs on Windows instead of invoking `mklink`
and parsing `dir` output. This supports directory links, raises on
creation failures, and lets the restored specs exercise real symlinks
with `core.symlinks=true`. Ten additional examples cover files,
directories, missing targets, spaces, and creation errors.

Repair the parallelism regression spec: its previous built-in hook
ignored the configured sleep command. An ad hoc serial hook now actually
sleeps and writes a marker; the spec requires a successful commit and
verifies the marker. Allow 30 seconds for Git and interpreter startup on
slower Windows runners instead of the flaky five-second deadline. Two
additional examples cover unavailable Windows process information.

Validation:

- Local Ruby 3.4.7: full suite with 1,679 examples and zero failures;
the strengthened para... (continued)

8 of 8 new or added lines in 3 files covered. (100.0%)

3325 of 3597 relevant lines covered (92.44%)

6572.07 hits per line