pyro-ppl / numpyro / 41934656343

93%

push

github

feat(gh-1989): check base support against the transform domain in TransformedDistribution (#2381)

* feat(gh-1989): check base support against the transform domain in TransformedDistribution

When validation is enabled, raise a ValueError if the support of the base
distribution is clearly outside the domain of the first transform
(e.g. Normal with ExpTransform().inv). Only interval-like constraints
(real, interval, greater_than, less_than and their integer/independent
variants) with concrete bounds are compared. Other constraints, traced
bounds and differences only at the end points are not reported.

Closes #1989

* refactor(gh-1989): move the domain check into Constraint.is_subset

Constraints now declare whether they are a subset of another constraint.
Interval-like constraints (real, interval, greater_than, less_than and the
integer variants) compare their bounds; everything else is undecided and
returns None, so TransformedDistribution only raises when the base support
is known to extend beyond the transform domain.

* refactor(gh-1989): make the bounds check private and document its closure semantics

- Rename Constraint.is_subset to the private Constraint._bounds_within and
  document that end points and integrality are ignored.
- Return None when a continuous constraint is compared with a discrete one.
- Give extended_real interval bounds so that real is within extended_real.
- Raise RuntimeError for traced bounds when validate_args(strict=True).
- Assert that samples and log_prob are finite in the support-in-domain test.

---------

Co-authored-by: Koji Miyazawa <24467062+kojikojikojikoji@users.noreply.github.com>

45 of 47 new or added lines in 2 files covered. (95.74%)

15885 of 17094 relevant lines covered (92.93%)

1.7 hits per line