supabase / supabase-swift / 41921752561

96%

push

github

feat(auth): cancel the web auth session with the task and listen for HTTPS callbacks (#1720)

* feat(auth): cancel the web auth session with the task and listen for HTTPS callbacks

Cancelling the task that awaits ASWebAuthenticationSessionPresenter now
cancels the session. An HTTPS redirect URL uses Callback.https(host:path:)
on iOS 17.4, macOS 14.4, tvOS 17.4, visionOS 1.1 and watchOS 10.4 and later.
Only one page can be open at a time, and the default anchor comes from
AuthPlatform.

WebAuthPresenter gains authenticate(url:redirectURL:), which forwards the
scheme by default, so existing presenters keep compiling.

Fixes SDK-2079

* refactor(auth): trim the web auth session handle and the presenter tests

* fix(auth): keep the web auth presenter from hanging or failing to compile after a cancel

A task cancel now throws CancellationError even when the system never calls
back, a session that cannot start throws instead of waiting, a task that is
already cancelled opens no page, and the tvOS build skips the unavailable
cancel(). An HTTPS callback keeps the redirect's trailing slash.

* fix(auth): keep the one-page slot until a tvOS page closes

On tvOS, cancel() does not close the page. Cancelling the task now frees the
slot only when the system reports that the user closed the page. A lease makes
a late release safe, so it cannot free the slot of a later page.

105 of 136 new or added lines in 3 files covered. (77.21%)

14528 of 15300 relevant lines covered (94.95%)

432295.37 hits per line