stacklok / toolhive / 41910049034

73%

Build Type

push

github

Committed by web-flow

Commit Message

Merge commit from fork

* Move JSON object member helpers to pkg/mcp

The object member decoder and the canonical member check that the authz list filters use to reject duplicate and case-folded members move from pkg/authz to pkg/mcp and are exported, so that the tools/list filter in pkg/mcp can resolve members the same way.
The object and array encoders that write members back as they were read, with replacement values by exact member name, move with them, so that both filters share one codec.
pkg/authz already imports pkg/mcp, so this is the direction that avoids an import cycle.
The authz filters behave as before.
New tests check the member decoder and encoders, and that the canonical member check agrees with how encoding/json binds member names to struct fields.

Signed-off-by: Aleksandr Filippov <71711753+alex-feel@users.noreply.github.com>

* Fail closed on ambiguous tools/list responses

The tools/list filter treated a response as a tools list only when encoding/json decoded it into the filter's struct without error, and wrote any other response through unchanged.
A list it could not decode, or whose members encoding/json resolved differently from a client, therefore reached the client unfiltered.
The filter now checks whether a client could read the body as a tools list, as a JSON value or as an event stream, and filters such a body only when it resolves to one unambiguous list, withholding it otherwise.
A tools list has to be an array of objects, and the members the filter reads or rewrites (jsonrpc, id, result, tools, and each tool's name and description) must occur once under their canonical spelling, using the same case folding encoding/json applies when it binds members to struct fields.
A batch, or a body with data after a complete list, is withheld.
Event streams are filtered per event, with an event's data lines joined the way clients join them, and an event is written once its closing blank line arrives or the response ends.
A stream ... (continued)

Coverage Stats

861 of 928 new or added lines in 7 files covered. (92.78%)

71 existing lines in 6 files now uncovered.

93556 of 128734 relevant lines covered (72.67%)

851.13 hits per line