NVIDIA / nodewright / 41897882347

84%

Build Type

push

github

Committed by web-flow

Commit Message

perf(operator): avoid namespace scans for node Jobs and Job pods (#958)

* perf(operator): avoid namespace scans for node Jobs and Job pods

Repeated label-only cache queries scan every Job or pod in the namespace.
Their cost grows with namespace object counts, even when a query needs
only one node's Jobs or one Job's pods.

Use indexes keyed by the existing labels to narrow each query's candidates
before applying its label selectors. Share index registration so either
reconciler can initialize without depending on the other's setup.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Taylor Daugherty <tdaugherty@nvidia.com>

* refactor(operator): register cache field indexes once from main

Replace the per-manager sync.Map guard with an exported
SetupFieldIndexes that main calls once before setting up the
reconcilers. Tests that start a manager call it too.

Rename the two new index keys so they cannot be mistaken for apiserver
field selectors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Taylor Daugherty <tdaugherty@nvidia.com>

* fix(operator): wrap field index errors and assert the childPods index

Name the resource and index in each SetupFieldIndexes error. Assert that
childPods lists pods through the Job UID field index, so dropping the
index fails the test even though the label selector returns the same
pods.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Taylor Daugherty <tdaugherty@nvidia.com>

* Update operator/internal/controller/skyhook_controller.go

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

---------

Signed-off-by: Taylor Daugherty <tdaugherty@nvidia.com>
Signed-off-by: Brian Lockwood <lockwobr@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Brian Lockwood <lockwobr@gmail.com>

Coverage Stats

25 of 36 new or added lines in 3 files covered. (69.44%)

12 existing lines in 2 files now uncovered.

10505 of 12494 relevant lines covered (84.08%)

7.69 hits per line