mongodb-js / devtools-shared / 41896510494

81%

push

github

fix(mongodb-runner): DRIVERS-3673 keep server logs after `mongodb-runner start` exits (#946)

* fix(mongodb-runner): keep server logs after `mongodb-runner start` exits

With `--logDir` set, each server's stdout and stderr were piped through the runner process into the
log file. `mongodb-runner start` exits once the cluster is up, so nothing wrote to those files
afterward and every log ended at startup.

This redirects the server's stdout and stderr straight to the log file instead, so the server keeps
logging on its own. The runner follows the file to read the startup output (port and build info)
that it previously got from the pipe.

Log files are now named `<binary>-<uuid>-<timestamp>.log` rather than using the pid, since the pid
isn't known before the file has to exist.

stderr now shares the file the runner parses, so lines that aren't log entries (for example docker's
"Unable to find image") are skipped instead of ending the log stream and failing startup.

2249 of 3075 branches covered (73.14%)

Branch coverage included in aggregate %.

59 of 63 new or added lines in 3 files covered. (93.65%)

4808 of 5690 relevant lines covered (84.5%)

765.35 hits per line