• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tari-project / tari / 41829828991
79%

Build:
DEFAULT BRANCH: development
Ran 04 Nov 2026 02:30PM UTC
Jobs 1
Files 799
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

04 Nov 2026 12:30PM UTC coverage: 77.844% (+0.2%) from 77.644%
41829828991

push

github

web-flow
fix(chain-storage): keep orphan chain tips consistent and bound the RandomX keys gossip can select (#8246)

Description
---

The node keeps blocks it cannot add to its main chain yet in an orphan
pool, with an index of the chain tips there. On each new block it reorgs
to the strongest of those tips. This PR fixes several ways that index
could go wrong. It also makes orphan and side-chain headers take their
RandomX VM key from their own chain. The gossip pre-check now limits
which RandomX keys a peer can make the node use.

**Orphan chain tips**
- **Invalid children no longer hide a valid parent.** A parent stops
being a tip only after the child that replaces it passes validation. If
every held child of a block fails, that block becomes a tip again.
- **Header failures are classified in one place, and the orphan insert
and the descendant walk share it.**
- *Storage faults* (`FatalStorageError`, `StoredDataError`) are returned
and nothing is deleted.
- *Failures that may later pass or aren't about the block* (future time
limit, seed age, a wrong timestamp count, a local RandomX VM build
failure) delete only the child.
- *Definitely invalid headers* delete the child and everything built on
it.
  - The walk never writes to `bad_blocks`.
- **No hidden blocks.** The candidate block is stored and made a tip in
one write, so a walk that fails afterwards can't leave a stored block
that is neither a tip nor reachable.
- **Tips are indexed with their own accumulated work.** Before, they
could be indexed with an ancestor's work, which let a stale tip mask a
stronger fork. A rewound tip is also indexed with its own work. A rewind
past the pruning horizon no longer leaves a tip that points at nothing.
- **Broken index entries are repaired.** Reading the strongest tips
skips entries whose orphan or accumulated data is missing, and the next
write repairs them. Startup also re-indexes every tip from its
accumulated data.
- **Eviction removes whole subtrees.** Before, ... (continued)

1093 of 1295 new or added lines in 6 files covered. (84.4%)

51 existing lines in 11 files now uncovered.

144039 of 185035 relevant lines covered (77.84%)

1129072.63 hits per line

Uncovered Changes

Lines Coverage ∆ File
171
64.0
2.47% base_layer/core/src/chain_storage/blockchain_database.rs
27
66.62
1.61% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
4
83.23
9.64% base_layer/core/src/base_node/comms_interface/inbound_handlers.rs

Coverage Regressions

Lines Coverage ∆ File
17
94.28
-0.53% base_layer/core/src/base_node/sync/horizon_state_sync/synchronizer.rs
9
64.0
2.47% base_layer/core/src/chain_storage/blockchain_database.rs
6
66.62
1.61% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
4
72.94
-0.07% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
4
77.52
-0.03% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
3
91.26
-0.46% comms/core/src/connection_manager/listener.rs
3
67.49
-1.48% comms/core/src/connectivity/requester.rs
2
82.81
-3.13% comms/core/src/pipeline/outbound.rs
1
86.99
-0.23% base_layer/core/src/mempool/service/service.rs
1
90.92
-0.16% base_layer/p2p/src/services/liveness/service.rs
1
78.57
-1.43% comms/core/src/test_utils/mocks/connection_manager.rs
Jobs
ID Job ID Ran Files Coverage
1 41829828991.1 04 Nov 2026 02:30PM UTC 799
77.84
GitHub Action Run
Source Files on build 41829828991
  • Tree
  • List 799
  • Changed 34
  • Source Changed 9
  • Coverage Changed 34
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #41829828991
  • b3aeec59 on github
  • Prev Build on development (#41611521299)
  • Next Build on development (#41987697257)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc