• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Eyevinn / mp4ff / 41835676387
85%

Build:
DEFAULT BRANCH: master
Ran 04 Nov 2026 01:10PM UTC
Jobs 1
Files 237
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

04 Nov 2026 01:10PM UTC coverage: 84.235% (+0.002%) from 84.233%
41835676387

push

github

tobbee
fix(mp4): read the fields of QuickTime atoms from a reader that is not a FixedSliceReader

Since 6f2cdd6, decodeOrUnknownSR reads the payload with one ReadBytes and decodes it from a bits.FixedSliceReader of its own. A bits.SliceReader that records the reads, as mp4lens does to show the byte layout of a box, then saw one read of the whole payload instead of the fields, for alis, chan, chpl, gmin, keys, mean, tcmi, tmcd, clef/prof/enof, text, tx3g, ftab and the ProRes sample entries.

decodeOrUnknownSR now decodes from a bits.FixedSliceReader as before, once, from a reader of its own. From another bits.SliceReader, decodeCopyOrUnknownSR first decodes a copy of the payload from a bits.FixedSliceReader and, if that works, decodes again from the reader, or returns an UnknownBox. The copy decodes the boxes below it once each, so the time grows with the square of the nesting instead of doubling per level, and boxes nested far deeper than MaxBoxDepth still give ErrBoxTooDeep.

TestDecodeOrUnknownOnOtherReader counts the reads in the payloads of chan, alis and a QuickTime text entry on a recording reader (1 each before the fix), and checks that a too short alis becomes an UnknownBox that ends where the box ends. TestNestedBoxesOnOtherReader decodes 64 nested gmhd, tapt and tmcd boxes within 10 s and gets ErrBoxTooDeep for 128.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EagxH5xE2UAmVD7tQWREtL

13 of 15 new or added lines in 1 file covered. (86.67%)

26998 of 32051 relevant lines covered (84.23%)

0.84 hits per line

Uncovered Changes

Lines Coverage ∆ File
2
84.51
0.58% mp4/unknown.go
Jobs
ID Job ID Ran Files Coverage
1 41835676387.1 04 Nov 2026 01:10PM UTC 237
84.23
GitHub Action Run
Source Files on build 41835676387
  • Tree
  • List 237
  • Changed 1
  • Source Changed 0
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • fb2cd04e on github
  • Prev Build on master (#41810494326)
  • Next Build on master (#42820507308)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc