supabase / supabase / 41815160314

87%

push

github

fix(studio): handle unknown upgrade warning types (#52775)

Fixes a page crash on Project Settings > General. The upgrade
eligibility API now returns a warning type
(`collation_reindex_required`) that Studio doesn't handle, so
`getWarningLink` returned `undefined` and `<Link href={undefined}>`
threw in `resolveHref`, taking the page down via the global error
boundary.

**Changed:**
- Added `default` cases to the warning title, description, and link
helpers in `UpgradeWarnings.tsx`. Unknown warning types now show generic
copy and link to the specific upgrade notes section of the docs, rather
than being hidden or crashing.

**Added:**
- `UpgradeWarnings.test.tsx`, covering a known warning type and an
unknown one. The unknown case failed with `href` undefined before this
change.

**Not in this PR:**
- Dedicated copy for `collation_reindex_required`. That needs
regenerated `api-types` and an upgrade guide section, which doesn't
exist yet.
- Open tabs on old bundles keep crashing until they reload, since this
fix only reaches new bundles.

## To test

- Open Project Settings > General on a project whose
`/upgrade/eligibility` response includes `collation_reindex_required`.
The page should load and show "Review the upgrade notes before
upgrading".
- Check that "Read upgrade notes" goes to the specific upgrade notes
section of the upgrading guide.
- Check that a known warning type, such as `ltree_reindex_required`,
still shows its own copy and link.

Co-authored-by: Alaister Young <10985857+alaister@users.noreply.github.com>

1988 of 2358 branches covered (84.31%)

Branch coverage included in aggregate %.

2805 of 3163 relevant lines covered (88.68%)

196.04 hits per line