• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Eyevinn / mp4ff / 41807873785
85%

Build:
DEFAULT BRANCH: master
Ran 04 Nov 2026 09:29AM UTC
Jobs 1
Files 237
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

04 Nov 2026 09:29AM UTC coverage: 84.233% (+0.002%) from 84.231%
41807873785

push

github

tobbee
fix(avc): drop the zero bytes after NAL units in ConvertByteStreamToNaluSample

ConvertByteStreamToNaluSample only removed the zero byte of a 4-byte start code. Other zero bytes before a start code, and at the end of the stream, stayed in the NAL unit before them, although a NAL unit never ends with a zero byte (ISO/IEC 14496-10, 7.4.1) and they are trailing_zero_8bits of the byte stream (Annex B). The other Annex B functions already drop them with trimTrailingZeros, which this function now uses too.

cmd/mp4ff-nallister/testdata/4pics.264 is padded with zero bytes to 6667 bytes per frame. Its NAL units were reported as 6575 (IDR), 6623 and 6624 bytes, and are now 1732, 347 and 200 bytes, as ExtractNalusFromByteStream gives them.

With only 4-byte start codes the conversion is still in place, with each NAL unit moved down over the dropped bytes. That path also drops bytes before the first start code, as the copying path did; it used to keep them before the first length field. A stream without start codes is still returned unchanged.

TestConvertByteStreamToNaluSample converted two-frames.264, which is length-prefixed and has no start codes, so it only checked that the stream was returned as it was. It now builds byte streams from the NAL units of that file, with 3- and 4-byte start codes, zero bytes around the NAL units and a start code at the end, and checks that they convert back to the file. BenchmarkByteStreamToNaluSample shows no significant change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Claude-Session: https://claude.ai/code/session_01EagxH7ENAVwUPJWTRiw1wQ

21 of 21 new or added lines in 1 file covered. (100.0%)

3 existing lines in 2 files now uncovered.

26985 of 32036 relevant lines covered (84.23%)

0.84 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
98.98
0.03% avc/annexb.go
1
97.47
-0.03% hevc/annexb.go
Jobs
ID Job ID Ran Files Coverage
1 41807873785.1 04 Nov 2026 09:29AM UTC 237
84.23
GitHub Action Run
Source Files on build 41807873785
  • Tree
  • List 237
  • Changed 3
  • Source Changed 0
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 0558cfb1 on github
  • Prev Build on master (#41800347956)
  • Next Build on master (#41810494326)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc