solidjs / solid / 41740703426

78%

main: 89%

push

github

fix(signals): store proxies keep the source prototype (#4670) (#4674)

* fix(signals): store proxies keep the source prototype (#4670)

A store proxy's target is an empty `{}`/`[]` (core R51 target indirection,
`Array.isArray`), and there was no `getPrototypeOf` trap, so `instanceof`,
`Object.getPrototypeOf` and `.constructor` answered Object/Array for array
subclasses and class instances (core R48 says those wrap).

- store traps: `getPrototypeOf` forwards the backing's prototype. The shell
  is always extensible (`preventExtensions` refuses), so the proxy invariant
  allows any answer.
- projection draft wrapper: the same trap, forwarding to the store proxy.
- cloneRaw: an array subclass with named keys/accessors cloned to a plain
  array on the first write, dropping its methods; the clone is now
  re-prototyped to the source's.
- core R30: the inherited-`constructor` read guard is scoped to drafts
  (setter and projection derive), as in the pre-rewrite store; a plain read
  answers the class. Inherited `__proto__`/`prototype` stay unserved
  everywhere.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

* perf(signals): golf the #4670 prototype fix to net -8 B minified

Alias `Object.getPrototypeOf`/`Object.setPrototypeOf` once in store.ts
(`protoOf`/`setProto`, the former shared with the projection draft
wrapper) and reuse them at every existing call site; `cloneRaw` builds
its non-slice clone through one `Object.defineProperties` over either a
re-prototyped `[]` or `Object.create(proto)`. Behaviour is unchanged
from the previous commit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWNSSgtemsSYsaX2hXE

---------

Co-authored-by: Claude <noreply@anthropic.com>

807 of 1108 branches covered (72.83%)

Branch coverage included in aggregate %.

1132 of 1370 relevant lines covered (82.63%)

30.31 hits per line