• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubeflow / trainer / 41717533696
81%

Build:
DEFAULT BRANCH: master
Ran 03 Nov 2026 09:05PM UTC
Jobs 1
Files 48
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

03 Nov 2026 08:58PM UTC coverage: 80.768% (+0.8%) from 79.98%
41717533696

push

github

web-flow
fix(controller): validate status server tokens with TokenReview (#4371)

* fix(statusserver): validate status server tokens with TokenReview

The status server verified projected service account tokens locally with
OIDC discovery against the issuer found in the controller's own token. On
clusters whose service account issuer is not served in-cluster (EKS, GKE,
AKS, OpenShift with a custom issuer), discovery leaves the cluster using
the in-cluster client, which only trusts the cluster CA and attaches the
controller's token. The authorizer then fails to initialize and the whole
controller manager exits. Since OptimizationJob requires TrainJobStatus,
OptimizationJob cannot be enabled on those clusters at all.

Validate tokens with the TokenReview API instead, as originally specified
in KEP-2779. The API server checks the signature, expiry, bound pod and
the TrainJob-specific audience, and the authorizer requires the token to
belong to a service account in the TrainJob namespace. This works with any
issuer, rejects tokens of deleted pods, and makes no request at startup.
Reviews use the manager client so they do not consume the status server
client rate limits. The tokenreviews RBAC is already granted.

This also drops the github.com/coreos/go-oidc dependency.

Signed-off-by: Akshay Chitneni <achitneni@apple.com>

* test(statusserver): wait past the API server token cache for bound pod deletion

The API server caches successful token authentications for 10 seconds by
default, so a token reviewed right before its bound pod is deleted can
still be authorized until the cache entry expires. Wait longer than the
cache TTL instead of the default 5 second timeout.

Signed-off-by: Akshay Chitneni <achitneni@apple.com>

* fix(statusserver): review tokens with the status server client and log rejections

Review tokens with the status server client instead of the manager client,
so requests with arbitrary bearer tokens can only consume the status server
rate limits ... (continued)

24 of 25 new or added lines in 3 files covered. (96.0%)

4036 of 4997 relevant lines covered (80.77%)

0.81 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
21.57
0.0% pkg/statusserver/setup.go
Jobs
ID Job ID Ran Files Coverage
1 41717533696.1 03 Nov 2026 09:05PM UTC 48
80.77
GitHub Action Run
Source Files on build 41717533696
  • Tree
  • List 48
  • Changed 2
  • Source Changed 0
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 2d544a44 on github
  • Prev Build on master (#41685135694)
  • Next Build on master (#41719892762)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc