• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Eyevinn / mp4ff / 41641901003
85%

Build:
DEFAULT BRANCH: master
Ran 03 Nov 2026 01:10PM UTC
Jobs 1
Files 236
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

03 Nov 2026 01:09PM UTC coverage: 84.173% (+0.1%) from 84.026%
41641901003

push

github

tobbee
feat(aac): decode program config elements and follow the ASC extension rules

Completes PR #657 along its review:

- Channel configuration 0 decodes its program_config_element (ISO/IEC 14496-3:2019 Table 4.2) into the new ProgramConfigElement, with the byte alignment before the comment field counted from the start of the AudioSpecificConfig, and Encode writes it back. The FATE suite configs with a PCE, including the AAC Main conformance streams am00_88 and am05_44, decode with the channel counts that ffprobe reports and re-encode byte for byte.
- Sync extensions are only looked for under the conditions of Table 1.19: 0x2b7 if SBR is not signalled explicitly and at least 16 bits are left, then 0x548 if at least 12 bits are left. Unknown sync words, unknown extension object types and other leftover bits are ignored instead of rejected, so configs with trailing zero bytes, such as those of twofields_packet.mp4 and mov_stream_shorter_than_movie.mov, decode again. In the 2019 edition the 0x548 check is outside the sbrPresentFlag condition, so a PS sync extension after an SBR flag of 0 is read and written too.
- Decode errors return the fields decoded so far, as master did for an unsupported object type or frequency index. Escaped object types are reported with their value, such as 39 for ER AAC ELD.
- AudioSpecificConfig.NrChannels gives the channel count from the channel configuration or the PCE. SetAACDescriptorFromConfig uses it and rejects configs without channels, such as the reserved channel configurations 8-10 and 15.
- Tests cover AAC Main, frameLengthFlag, the core coder delay, sync extensions with SBR on and off and with and without PS, PCEs, trailing bits, the validation errors, CoreSamplesPerFrame and SetAACDescriptorFromConfig. Coverage of aac goes from 90.3% on master to 95.6%.

Of the 63 distinct AAC configs in the FATE suite, the 40 that master decodes still decode, and so do am00_88 and am05_44. 40 of these 42 re-encode byte for byte; the ... (continued)

261 of 269 new or added lines in 3 files covered. (97.03%)

10 existing lines in 2 files now uncovered.

26746 of 31775 relevant lines covered (84.17%)

0.84 hits per line

Uncovered Changes

Lines Coverage ∆ File
8
93.56
5.52% aac/aac.go

Coverage Regressions

Lines Coverage ∆ File
6
93.56
5.52% aac/aac.go
4
87.87
0.96% mp4/initsegment.go
Jobs
ID Job ID Ran Files Coverage
1 41641901003.1 03 Nov 2026 01:10PM UTC 236
84.17
GitHub Action Run
Source Files on build 41641901003
  • Tree
  • List 236
  • Changed 2
  • Source Changed 0
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 80947f97 on github
  • Prev Build on master (#41617824107)
  • Next Build on master (#41642903435)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc