Mellanox / network-operator / 41629357005

65%

Build Type

push

github

Committed by web-flow

Commit Message

fix: preserve the MFT configuration path in NIC daemon (#3628)

Set `MFT_CONFIG_PATH=/etc/mft/mft.conf` in the NIC configuration daemon
unless the NicClusterPolicy supplies that variable. MFT SDK
initialization currently selects a missing SDK-specific configuration,
causing subsequent DMS-launched `mlxreg` commands to fail.

Preserve explicit values and `valueFrom` entries without duplicate
environment variables or mutation of the policy. The equivalent
environment workaround was verified with successful DMS queries and an
eight-NIC configuration pass on the VR lab.

Tracks [MFT P2 #5383497](https://redmine.nvidia.com/issues/5383497).

Validation on both PR branches:

- `go test ./pkg/state -count=1 -v`: 244 specs passed on each branch,
including seven committed rendering cases covering nil/empty/unrelated
env, custom/default/empty explicit values, and `valueFrom`. The tests
also verify one MFT entry, repeated reconciliation, policy preservation,
and daemon-only defaulting.
- `go build ./...` passed on both branches before adding the test-only
changes.

Coverage Stats

6 of 6 new or added lines in 1 file covered. (100.0%)

14 existing lines in 4 files now uncovered.

5476 of 8403 relevant lines covered (65.17%)

92.16 hits per line