microsoft / RulesEngine / 41628730267

95%

master: 97%

push

github

Fix EvaluateRule action failing when the target workflow has GlobalParams (#626) (#760)

The inputs an EvaluateRule action forwards come from RuleResultTree.Inputs,
which already holds the source rule's evaluated GlobalParams. The target
workflow then evaluates its own GlobalParams again, so chaining into any
workflow with globals failed with "The identifier 'x' was defined more than
once" (or a GlobalParam/input collision error).

EvaluateRuleAction now drops forwarded params named like the target
workflow's GlobalParams before the call; the target recomputes them from the
remaining inputs. Names are compared the way the expression parser compares
identifiers (IsExpressionCaseSensitive), nothing is dropped when
EnableScopedParams is off, and additionalInputs are added after the drop so
they behave as before.

Co-authored-by: MBrekhof <martin.brekhof@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: YogeshPraj <yoprajap@microsoft.com>

502 of 628 branches covered (79.94%)

9 of 10 new or added lines in 3 files covered. (90.0%)

890 of 940 relevant lines covered (94.68%)

870.05 hits per line