41617201362
94%

Ran 03 Nov 2026 10:14AM UTC

Jobs 1

Files 86

Run time 1min

Badge

Embed ▾

Committed 03 Nov 2026 10:11AM UTC coverage: 93.579% (+0.01%) from 93.568%

Build # 41617201362

Build Type

push

github

Committed by

web-flow

Commit Message

Reject confirmations on executed multisig transactions (#328)

* Reject confirmations on executed multisig transactions

POST /multisig-transactions/{safeTxHash}/signatures stored confirmations
for executed transactions, published NEW_CONFIRMATION and the transaction
service sync copied them back. The transaction service rejects them.

- The service rejects an executed transaction with 422 before reading the
  Safe or the signatures, with the transaction service message.
- Indexed APPROVED_HASH confirmations and the migration keep storing
  confirmations on executed transactions: an approveHash can be mined with
  the execution or after it.
- The lock wait test helper moves to AsyncDbTestCase, so other tests can
  use it.

* Return the executed message when deleting an executed transaction

DELETE on an executed transaction returned 422 with the generic
"Validation error occurred." detail. It now raises
MultisigTransactionAlreadyExecuted, the same as a new confirmation, so the
detail is "Transaction with safe-tx-hash=0x... was already executed".

* Add docstring to executed confirmation API test

Coverage Stats

3483 of 3722 relevant lines covered (93.58%)

0.94 hits per line

Coverage Regressions

Lines	Coverage	∆	File
7	97.06	0.02%	app/services/multisig_transaction_service.py
3	90.8	0.0%	app/api/v1/multisig_transaction/routers.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	41617201362.1	03 Nov 2026 10:14AM UTC	86	93.58	GitHub Action Run

safe-global / safe-queue-service / 41617201362
94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 41617201362

safe-global / safe-queue-service / 41617201362 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 41617201362

safe-global / safe-queue-service / 41617201362
94%

README BADGES
x