IgniteUI / igniteui-webcomponents / 41612381274

100%

push

github

fix: focus before render (#2569)

* fix: stop focus() and blur() from throwing before the first render

- Radio, checkbox, switch and select read their inner input with a cached
  query that is null until the first render. A focus() or blur() call
  right after the element connected threw a TypeError. The calls now do
  nothing, as in the other components.
- Add deferFocus() and cancelDeferredFocus() to internals. They store a
  focus() call on a connected component that has not rendered and repeat
  it after the first update. A later request, a focusin or a cancel drops
  the stored call. No component uses them yet.
- Add the runFocusBeforeRenderTests() spec helper. It checks this behavior
  for a component.

* fix: apply focus() calls made before the first render

- A focus() call on a component right after it connects now moves the
  focus to the component after its first render, as on a native control.
  Before, the call did nothing. A blur() of the component, or a focus
  change before the render, cancels the call.
- This applies to the button, icon button, toggle button, carousel,
  checkbox, switch, radio, chip, color picker, combo, select, date picker,
  date range picker, date time input, file input, input, mask input,
  rating, slider, range slider and textarea. In the carousel, the focus
  can go to a navigation button, because the indicators render after the
  carousel finds its slides.
- The button, icon button, carousel, chip, color picker, date picker,
  date range picker and textarea now list focus() and blur() in their
  API.
- The specs use the shared runFocusBeforeRenderTests() suite. The
  spec.md files and the CHANGELOG describe the change.

* refactor: simplify the deferred focus and stop a repeat loop

- All 16 components use one form: they focus the inner target or call
  super.focus(), then call deferFocus(). The inner target is read once.
- deferFocus() returns nothing and checks hasUpdated first. It skips a
  host with disab... (continued)

8871 of 8970 branches covered (98.9%)

Branch coverage included in aggregate %.

267 of 267 new or added lines in 16 files covered. (100.0%)

53988 of 54111 relevant lines covered (99.77%)

3779.32 hits per line