• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tarantool / tarantool / 41544283808
88%

Build:
DEFAULT BRANCH: master
Ran 02 Nov 2026 11:33PM UTC
Jobs 1
Files 526
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

02 Nov 2026 11:17PM UTC coverage: 88.141% (+0.03%) from 88.113%
41544283808

push

github

Gerold103
sql: calculate expression tree height on AST

Before this patch, the height of an expression tree was calculated on
`struct Expr` while the AST was converted into it, and was checked
against `SQL_MAX_EXPR_DEPTH` during the conversion. Now the height is
calculated when an expression is built in the AST and is checked before
the expression is converted. The height of `struct Expr` is set from
the AST. The check of the total height of the nested subqueries during
name resolution and code generation is kept, and now uses the heights
calculated on the AST.

This fixes a bug where the COLLATE expression reset the height counter,
so an expression with COLLATE could exceed the limit without an error.

Also, the AST was converted recursively before the height was checked,
so a long enough chain of binary operators or COLLATE clauses overflowed
the stack. Now the height is checked before the conversion.

Note that the height is now counted on the expression as written,
without constant folding, so the operands of `x AND FALSE` and `x IN ()`
are counted too. Also, the error now reports the height of the whole
expression instead of the height at which the limit was first exceeded.

Closes #13205

NO_DOC=bugfix

72888 of 121714 branches covered (59.88%)

65 of 67 new or added lines in 2 files covered. (97.01%)

129 existing lines in 19 files now uncovered.

109488 of 124219 relevant lines covered (88.14%)

1437418.91 hits per line

Uncovered Changes

Lines Coverage ∆ File
2
93.35
2.53% src/box/sql/ast.c

Coverage Regressions

Lines Coverage ∆ File
47
93.35
2.53% src/box/sql/ast.c
38
94.46
-0.05% src/box/sql/parse.c
9
97.78
1.13% src/box/sql/parse.y
6
95.22
-1.25% src/box/vy_read_iterator.c
4
93.31
-1.27% src/lib/swim/swim_io.c
3
92.67
-0.13% src/box/vinyl.c
3
92.45
-0.3% src/box/vy_scheduler.c
2
94.54
0.21% src/box/sql/expr.c
2
95.61
0.15% src/box/sql/tokenize.c
2
89.74
-0.09% src/box/xrow.c
2
93.81
0.0% src/box/xrow_update_field.c
2
94.39
-0.01% src/lib/core/fiber.c
2
95.45
-4.55% src/lib/json/json.h
2
22.68
-0.04% src/lib/uri/uri_parser.c
1
95.74
-0.53% src/box/vy_range.c
1
61.49
-0.68% src/lib/core/fio.c
1
96.55
-1.15% src/lib/core/histogram.c
1
92.07
-0.11% src/lib/swim/swim.c
1
97.35
-0.88% src/lib/vclock/vclock.c
Jobs
ID Job ID Ran Files Coverage
1 41544283808.1 02 Nov 2026 11:33PM UTC 526
88.14
GitHub Action Run
Source Files on build 41544283808
  • Tree
  • List 526
  • Changed 37
  • Source Changed 0
  • Coverage Changed 37
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • be011715 on github
  • Prev Build on master (#41527334873)
  • Next Build on master (#41618678939)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc