• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubernetes-sigs / external-dns / 41536890460
84%

Build:
DEFAULT BRANCH: master
Ran 02 Nov 2026 10:29PM UTC
Jobs 2
Files 168
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

02 Nov 2026 10:23PM UTC coverage: 83.282% (+0.06%) from 83.22%
41536890460

push

github

web-flow
feat(crd): report an Accepted condition on DNSEndpoint (#6768)

* feat(crd): report an Accepted condition on DNSEndpoint

A malformed endpoint is dropped today with a log line the user never sees.
DNSEndpointStatus gains conditions and an Accepted print column. The crd source
sets Accepted (Accepted/Invalid) before any provider call, with a message that
names the offending spec.endpoints index and the fix.

The source now also refuses what dedupSource would drop silently later: a
relative SRV host, an MX target without a preference, and empty targets when
--default-targets is unset. Nothing changes at the provider; those endpoints
never reached it.

Rejected endpoints can raise a RecordInvalid warning event under --events-emit,
emitted only when the verdict changes. The emitter is now built before the
sources so they can emit, and defaults to events.Discard. Status writes are
gated on a diff, so a steady-state object costs no API writes.

Signed-off-by: Michel Loiseleur <michel.loiseleur@traefik.io>

* fix(chart): keep the DNSEndpoint CRD change out of the chart until release

The chart should only ship the Accepted condition once a released
ExternalDNS version supports it. A dedicated chart PR will add it then.

Signed-off-by: Michel Loiseleur <michel.loiseleur@traefik.io>

* feat(crd): default the Accepted condition to Unknown

Until an external-dns instance reads a DNSEndpoint, its Accepted condition
now shows Unknown with reason Pending instead of no status at all. The API
server applies schema defaults on read too, so existing objects get it
without a write.

The crd source docs now describe current validation only, and say that a
rejected endpoint does not block the rest of its object.

Signed-off-by: Michel Loiseleur <michel.loiseleur@traefik.io>

* ci(crd): copy CRDs into the chart only with make crd-chart

The chart ships a CRD change only once an ExternalDNS release supports it.
make crd used to rewrite the chart copy every time, so validate... (continued)

16439 of 19739 relevant lines covered (83.28%)

1471.76 hits per line

Coverage Regressions

Lines Coverage ∆ File
35
0.0
0.0% v1alpha1/zz_generated.deepcopy.go
14
93.91
5.42% crd.go
1
87.27
-0.91% openshift_route.go
Jobs
ID Job ID Ran Files Coverage
1 run-ubuntu-latest - 41536890460.1 02 Nov 2026 10:31PM UTC 168
83.28
GitHub Action Run
2 run-macos-latest - 41536890460.2 02 Nov 2026 10:29PM UTC 168
83.27
GitHub Action Run
Source Files on build 41536890460
  • Tree
  • List 168
  • Changed 3
  • Source Changed 0
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #41536890460
  • ce55f564 on github
  • Prev Build on master (#41535751551)
  • Next Build on master (#41539133647)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc