Knio / pynmea2 / 41536215487

98%

push

github

Return None for incomplete derived datetimes (recover #185) (#187)

Return None from .datetime and .datestamp when a field is blank

A sentence with no fix can have blank date and time fields, for
example $GPRMC,,V,,,,,,,,,N. Reading .datetime on it raised TypeError
because datetime.combine was given None. An empty ZDA sentence raised
TypeError when reading .datestamp, for the same reason.

Now .datetime returns None when the timestamp or datestamp is blank,
and ZDA.datestamp returns None when the day, month or year is blank.
The check is in the DatetimeFix mixin, so proprietary sentences that
use it behave the same way. Sentences with every field present behave
as before, and the coordinate helpers still return 0.0 for blank
coordinates.

Adds regression tests for the RMC and ZDA cases.

Refs #94

Co-authored-by: Erfouni <erfan.mohamadboland@gmail.com>

4 of 4 new or added lines in 2 files covered. (100.0%)

786 of 806 relevant lines covered (97.52%)

6.82 hits per line