synackd / ochami / 41516001504

93%

push

github

fix(smd): reject other selectors with delete --all (#226)

Return a usage error when compep, component, iface, or rfe delete is
given --all together with positional arguments or -d. Previously these
selectors were ignored with only a warning, so a command such as
"iface delete --all --no-confirm invalid/id" deleted every interface
even though the argument was invalid and the user likely meant a
narrower deletion. With -d, the payload was even validated and then
discarded.

Check the conflict in PreRunE so it fails before the confirmation
prompt, client creation, and any request. Read --all by value so that
--all=false still behaves as if --all were omitted. Keep the existing
warning for -d with positional arguments, since that combination never
widens deletion beyond the payload.

Document the restriction under each --all option in ochami-smd(1) and
drop the iface delete text describing --all taking precedence. Add
table tests per command for --all with a valid argument, an invalid
argument, and a payload, verifying a usage error and no request.

Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>

40 of 40 new or added lines in 4 files covered. (100.0%)

13088 of 14026 relevant lines covered (93.31%)

716.24 hits per line