nlohmann / json / 41506922054

100%

Build Type

push

github

Committed by web-flow

Commit Message

Fix the MSVC and GCC builds of develop (C4127, -Weffc++) (#6016)

json_view number(): #6006 folded the check of the digit after a minus
sign into `else if (!negative || ...)`, which MSVC 19.44 reports as
C4127 (conditional expression is constant) and /WX turns into an
error in every MSVC and clang-cl job. The check now sits in the
`if (negative)` block, right after the sign is skipped; the error and
its position are unchanged.

unit-locale-cpp.cpp: the locale_switching_token added in #5997 held a
`const char*`, so GCC's -Weffc++ asked for a copy constructor and copy
assignment. The locale name is now a std::string.

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

Coverage Stats

24412 of 73674 branches covered (33.14%)

3 of 3 new or added lines in 1 file covered. (100.0%)

3 existing lines in 2 files now uncovered.

16655 of 16699 relevant lines covered (99.74%)

5462511.19 hits per line