IgniteUI / igniteui-webcomponents / 41511081009

100%

push

github

fix: keep the events of inner components inside their composite hosts (#2568)

* fix(calendar): keep the events of the days view inside

The igcActiveDateChange and igcRangePreviewDateChange events of the inner
days view no longer reach the listeners on the calendar, the date picker
or the date range picker.

* fix(chat): keep the events of the text area and the attachment chips inside

The igcInput and igcChange events of the inner text area and the igcRemove
event of an attachment chip no longer reach the listeners on the chat.
Use igcInputChange and igcAttachmentRemoved instead.

* fix(color-picker): keep the events of the inner controls inside

The igcInput of the alpha input, the color value input and the input
anchor, the open and close events of the format select, and the
igcColorPicked of the canvas no longer reach the listeners on the color
picker. Before, a listener that canceled igcClosing on the picker also
kept the format select open.

* test: fail a spec file when an inner event reaches a component host

- The test runner loads a guard that records each igc* event of an
  element in the shadow root of a component that reaches the outermost
  component host. The file fails in a root after hook, with the test
  titles and the host chain of each leak.
- The combo virtual scroll events are a known exception until the #2530
  fix lands.
- The coding guidelines and the review skill get the rule: a composite
  stops the igc* events of the components in its shadow root.
- A real click on the checkbox of a tree item now has a spec. The item
  cancels the click, so the checkbox sends no igcChange to the tree.

* test: run the inner events checks after the root hooks of the spec files

The guard added its checks in mocha.setup(), so they ran before the
root afterEach and after hooks of a spec file, and a leak in such a hook
was never reported. A root before hook now adds the checks when the run
starts, after all root hooks of the spec files.

8801 of 8900 branches covered (98.89%)

Branch coverage included in aggregate %.

22 of 22 new or added lines in 3 files covered. (100.0%)

53727 of 53850 relevant lines covered (99.77%)

3757.4 hits per line