firezone / firezone / 41506728239

80%

Build Type

push

github

Committed by web-flow

Commit Message

fix(portal): only issue admin tokens to service accounts (#16180)

Admins could create a non-interactive client token for any user or
admin, not only for service accounts. The UI hides the button for other
actor types, but the `create_token` LiveView event did not check the
actor type, and the domain function had been widened to accept users in
#13358. With such a token an admin could connect as that user, and the
token survived removal of the user's identity or provider.

Non-interactive client tokens are now limited to service accounts in
both the domain function and the LiveView handler, matching what the
REST API already enforced.

Coverage Stats

1371 of 2287 branches covered (59.95%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

6 existing lines in 3 files now uncovered.

94548 of 117484 relevant lines covered (80.48%)

369111.93 hits per line